Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberInput never be touched #7980

Closed
bingluen opened this issue Jul 18, 2022 · 1 comment · Fixed by #7992
Closed

NumberInput never be touched #7980

bingluen opened this issue Jul 18, 2022 · 1 comment · Fixed by #7992
Assignees
@fzaninotto
Labels
bug

Comments

@bingluen
Copy link
Contributor

What you were expecting:
fieldState.isTouched of NumberInput should be set touched if field has received a focus and blur event.

What happened instead:
fieldState.isTouched always keep false, event touch it.

Steps to reproduce:

just touch NumberInput field and observe its state

Related code:

https://codesandbox.io/embed/cranky-yonath-zh60ob?fontsize=14&hidenavigation=1&module=%2Fsrc%2Fposts.js&theme=dark&view=editor

Other information:

Environment

  • React-admin version: 4.x
  • React version: 17
  • Browser: Edge 102.0.1245.33
@antoinefricker
Copy link
Contributor

antoinefricker commented Jul 20, 2022 •
edited
Loading

Reproduced, thanks for submitting this issue.
Duplicate of #7919 ?

@fzaninotto fzaninotto self-assigned this Jul 20, 2022
fzaninotto added a commit that referenced this issue Jul 20, 2022
@fzaninotto
Fix NumberInput field state isTouched is always false
a3563f9 
Closes #7980
@fzaninotto fzaninotto mentioned this issue Jul 20, 2022
Merged
Seojun-Park pushed a commit to Seojun-Park/react-admin that referenced this issue Oct 25, 2022
@fzaninotto @Seojun-Park
Fix NumberInput field state isTouched is always false
b84d3be 
Closes marmelab#7980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzaninotto fzaninotto

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NumberInput field state isTouched is always false marmelab/react-admin
3 participants
@fzaninotto @bingluen @antoinefricker