Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the Mobile menu doesn't need the logout button #6228

Closed
fzaninotto opened this issue Apr 30, 2021 · 1 comment
Closed

the Mobile menu doesn't need the logout button #6228

fzaninotto opened this issue Apr 30, 2021 · 1 comment
Assignees
@fzaninotto
Labels
good first issue

Comments

@fzaninotto
Copy link
Member

Problem

On Mobile, the Logout button appears twice: once in the main menu, and once in the user menu.

logout

It's confusing, and has no UX justification.

The reason is that it was added to the navigation menu before react-admin had a user menu. But when we added it to the user menu, we didn't remove it form the navigation menu.

Solution

Don't render the logout menu item in the navigation menu.
@fzaninotto fzaninotto self-assigned this Apr 30, 2021
fzaninotto added a commit that referenced this issue Apr 30, 2021
@fzaninotto
Fix logout button is displayed in two menus
903691d 
Closes #6228
@fzaninotto fzaninotto mentioned this issue Apr 30, 2021
Merged
fzaninotto added a commit that referenced this issue May 6, 2021
@fzaninotto
Fix logout button is displayed in two menus
b088fde 
Closes #6228
fzaninotto added a commit that referenced this issue May 6, 2021
@fzaninotto
Fix logout button is displayed in two menus
9c965a8 
Closes #6228
@fzaninotto
Copy link
Member Author

Fixed by #6230

ogustavo-pereira pushed a commit to ogustavo-pereira/react-admin that referenced this issue Nov 23, 2021
@fzaninotto @ogustavo-pereira
Fix logout button is displayed in two menus
703a027 
Closes marmelab#6228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzaninotto fzaninotto

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fzaninotto @djhi