Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сustom theme is not merged but replaced by default #5672

Closed
wmwart opened this issue Dec 15, 2020 · 1 comment · Fixed by #5676
Closed

Сustom theme is not merged but replaced by default #5672

wmwart opened this issue Dec 15, 2020 · 1 comment · Fixed by #5676
Assignees

Comments

@wmwart
Copy link

wmwart commented Dec 15, 2020

What you were expecting:
Expected custom theme to merge with default theme

What happened instead:
Сustom theme replaced the default theme
Documentation:

If you need more fine-tuning, you’ll need to write your own theme object, following Material UI themes documentation. Material UI merges custom theme objects with the default theme.

https://marmelab.com/react-admin/Theming.html#writing-a-custom-theme

Steps to reproduce:
https://codesandbox.io/s/confident-davinci-192ss

According to the documentation, and the latest changes with this theme configuration

  1. the theme should change to dark
  2. there should be no ripple effect on the buttons

however, as we can see the dark theme applied and the ripple effect returned

Environment

  • React-admin version: 3.11.0
  • Last version that did not exhibit the issue (if applicable): 3.9.6
@fzaninotto
Copy link
Member

Well spotted, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants