Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation message for deletion does not pick up resource translation #3040

Closed
straurob opened this issue Mar 22, 2019 · 0 comments
Closed

Comments

@straurob
Copy link

What you were expecting:
When deleting an item I expect the confirmation message to pick up the translated resource name. In the below screenshot that would be Staat or Staaten.

What happened instead:
The confirmation message shows the untranslated resource name staat.

image

Steps to reproduce:

  1. Setup translation messages (for the locale de) in i18n.js.
  2. Provide a resource named staat (or any other name).
  3. Open the list view.
  4. Select one or more entries.
  5. Click "Delete".
module.exports = {
  de: {
    resources: {
      staat: {
        name: "Staat |||| Staaten",
        fields: {
          // Fields go here...
        }
      }
    }
  }
}

Other information:
As far as I can see this seems to be related to BulkDeleteWithConfirmButton.js in the ra-ui-materialui package.

Environment

  • React-admin version: 2.8.2
  • React version: 16.8.4
  • Browser: Firefox 66.0
@straurob straurob changed the title Confirmation message for deletion does not pick up translation Confirmation message for deletion does not pick up resource translation Mar 22, 2019
@djhi djhi reopened this Mar 26, 2019
@djhi djhi closed this as completed Mar 26, 2019
@fzaninotto fzaninotto reopened this Mar 26, 2019
@fzaninotto fzaninotto added bug and removed enhancement labels Apr 2, 2019
@djhi djhi closed this as completed in #3086 Apr 3, 2019
ghodsizadeh pushed a commit to ghodsizadeh/react-admin that referenced this issue May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants