Merge pull request #3816 from marmelab/update-useCallback-dependencies

Make dependencies explicit to make code easier to understand
marmelab · Oct 14, 2019 · 90034e4 · 90034e4
2 parents a887d3e + 536c2da
commit 90034e4
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/packages/ra-core/src/controller/useSortState.ts b/packages/ra-core/src/controller/useSortState.ts
@@ -102,6 +102,7 @@ export const defaultSort = { field: 'id', order: 'DESC' };
  * @param {string} initialSort.order The initial sort order
  * @returns {SortProps} The sort props
  */
+
 export default (initialSort: Sort = defaultSort): SortProps => {
     const [sort, dispatch] = useReducer(sortReducer, initialSort);
     const isFirstRender = useRef(true);
@@ -116,17 +117,17 @@ export default (initialSort: Sort = defaultSort): SortProps => {
     return {
         setSort: useCallback(
             (sort: Sort) => dispatch({ type: 'SET_SORT', payload: { sort } }),
-            []
+            [dispatch]
         ),
         setSortField: useCallback(
             (field: string) =>
                 dispatch({ type: 'SET_SORT_FIELD', payload: { field } }),
-            []
+            [dispatch]
         ),
         setSortOrder: useCallback(
             (order: string) =>
                 dispatch({ type: 'SET_SORT_ORDER', payload: { order } }),
-            []
+            [dispatch]
         ),
         sort,
     };

diff --git a/packages/ra-ui-materialui/src/input/AutocompleteArrayInput.tsx b/packages/ra-ui-materialui/src/input/AutocompleteArrayInput.tsx
@@ -198,7 +198,7 @@ const AutocompleteArrayInput: FunctionComponent<
                 setFilter(value);
             }
         },
-        [setFilter]
+        [setFilter, setFilterValue]
     );
 
     // We must reset the filter every time the value changes to ensure we
@@ -235,7 +235,7 @@ const AutocompleteArrayInput: FunctionComponent<
             setFilterValue('');
             input.onChange(newSelectedItems.map(getChoiceValue));
         },
-        [getChoiceValue, input, selectedItems]
+        [getChoiceValue, input, selectedItems, setFilterValue]
     );
 
     const handleDelete = useCallback(
@@ -290,7 +290,7 @@ const AutocompleteArrayInput: FunctionComponent<
             handleFilterChange('');
             input.onBlur(event);
         },
-        [handleFilterChange, input]
+        [handleFilterChange, input, setFilterValue]
     );
 
     const handleFocus = useCallback(

diff --git a/packages/ra-ui-materialui/src/layout/Notification.tsx b/packages/ra-ui-materialui/src/layout/Notification.tsx
@@ -48,7 +48,7 @@ const Notification: React.FunctionComponent<
 
     const handleRequestClose = useCallback(() => {
         setOpen(false);
-    }, []);
+    }, [setOpen]);
 
     const handleExited = useCallback(() => {
         if (notification && notification.undoable) {

diff --git a/packages/ra-ui-materialui/src/list/FilterButton.js b/packages/ra-ui-materialui/src/list/FilterButton.js
@@ -42,19 +42,19 @@ const FilterButton = ({
             setOpen(true);
             anchorEl.current = event.currentTarget;
         },
-        [anchorEl]
+        [anchorEl, setOpen]
     );
 
     const handleRequestClose = useCallback(() => {
         setOpen(false);
-    }, []);
+    }, [setOpen]);
 
     const handleShow = useCallback(
         ({ source, defaultValue }) => {
             showFilter(source, defaultValue);
             setOpen(false);
         },
-        [showFilter]
+        [showFilter, setOpen]
     );
 
     if (hiddenFilters.length === 0) return null;