Remove empty interfaces and fix 2 potential bugs

marmelab · Oct 10, 2019 · 62a686a · 62a686a
1 parent 8136185
commit 62a686a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/packages/ra-ui-materialui/src/form/SimpleForm.js b/packages/ra-ui-materialui/src/form/SimpleForm.js
@@ -33,7 +33,9 @@ const SimpleForm = ({ initialValues, defaultValue, saving, ...props }) => {
 
     const submit = values => {
         const finalRedirect =
-            typeof redirect === undefined ? props.redirect : redirect.current;
+            typeof redirect.current === undefined
+                ? props.redirect
+                : redirect.current;
         const finalValues = sanitizeEmptyValues(finalInitialValues, values);
 
         props.save(finalValues, finalRedirect);

diff --git a/packages/ra-ui-materialui/src/form/TabbedForm.js b/packages/ra-ui-materialui/src/form/TabbedForm.js
@@ -47,7 +47,9 @@ const TabbedForm = ({ initialValues, defaultValue, saving, ...props }) => {
 
     const submit = values => {
         const finalRedirect =
-            typeof redirect === undefined ? props.redirect : redirect.current;
+            typeof redirect.current === undefined
+                ? props.redirect
+                : redirect.current;
         const finalValues = sanitizeEmptyValues(finalInitialValues, values);
 
         props.save(finalValues, finalRedirect);

diff --git a/packages/ra-ui-materialui/src/input/AutocompleteArrayInput.tsx b/packages/ra-ui-materialui/src/input/AutocompleteArrayInput.tsx
@@ -23,8 +23,6 @@ import InputHelperText from './InputHelperText';
 import AutocompleteSuggestionList from './AutocompleteSuggestionList';
 import AutocompleteSuggestionItem from './AutocompleteSuggestionItem';
 
-interface Props {}
-
 interface Options {
     suggestionsContainerProps?: any;
     labelProps?: any;
@@ -93,7 +91,7 @@ interface Options {
  * <AutocompleteArrayInput source="author_id" options={{ fullWidthInput: true }} />
  */
 const AutocompleteArrayInput: FunctionComponent<
-    Props & InputProps<TextFieldProps & Options> & DownshiftProps<any>
+    InputProps<TextFieldProps & Options> & DownshiftProps<any>
 > = ({
     allowEmpty,
     classes: classesOverride,

diff --git a/packages/ra-ui-materialui/src/input/AutocompleteInput.tsx b/packages/ra-ui-materialui/src/input/AutocompleteInput.tsx
@@ -23,8 +23,6 @@ import InputHelperText from './InputHelperText';
 import AutocompleteSuggestionList from './AutocompleteSuggestionList';
 import AutocompleteSuggestionItem from './AutocompleteSuggestionItem';
 
-interface Props {}
-
 interface Options {
     suggestionsContainerProps?: any;
     labelProps?: any;
@@ -93,7 +91,7 @@ interface Options {
  * <AutocompleteInput source="author_id" options={{ fullWidthInput: true }} />
  */
 const AutocompleteInput: FunctionComponent<
-    Props & InputProps<TextFieldProps & Options> & DownshiftProps<any>
+    InputProps<TextFieldProps & Options> & DownshiftProps<any>
 > = ({
     allowEmpty,
     classes: classesOverride,