Merge pull request #6146 from marmelab/fix-simplelistloading-warnings

Fix warnings when SimpleList displays skeleton while loading
marmelab · Apr 10, 2021 · 471a076 · 471a076
2 parents 8cba994 + 650979f
commit 471a076
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/ra-ui-materialui/src/list/Placeholder.tsx b/packages/ra-ui-materialui/src/list/Placeholder.tsx
@@ -21,7 +21,9 @@ interface Props {
 const Placeholder: FC<Props> = props => {
     const classes = useStyles(props);
     return (
-        <div className={classnames(classes.root, props.className)}>&nbsp;</div>
+        <span className={classnames(classes.root, props.className)}>
+            &nbsp;
+        </span>
     );
 };
 

diff --git a/packages/ra-ui-materialui/src/list/SimpleListLoading.tsx b/packages/ra-ui-materialui/src/list/SimpleListLoading.tsx
@@ -53,7 +53,7 @@ const SimpleListLoading: FC<Props & ListProps> = props => {
     return oneSecondHasPassed ? (
         <List className={className} {...rest}>
             {times(nbFakeLines, key => (
-                <ListItem>
+                <ListItem key={key}>
                     {hasLeftAvatarOrIcon && (
                         <ListItemAvatar>
                             <Avatar>&nbsp;</Avatar>