Merge pull request #4097 from marmelab/Fix-total-nan

Fix incorrect dataProvider leads to infinite render loop
marmelab · Dec 3, 2019 · 3f6ce19 · 3f6ce19
2 parents 3141cc8 + 24508a9
commit 3f6ce19
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/packages/ra-core/src/dataProvider/useQueryWithStore.ts b/packages/ra-core/src/dataProvider/useQueryWithStore.ts
@@ -117,12 +117,18 @@ const useQueryWithStore = (
         loaded: data !== undefined && !isEmptyList(data),
     });
     if (!isEqual(state.data, data) || state.total !== total) {
-        setState({
-            ...state,
-            data,
-            total,
-            loaded: true,
-        });
+        if (isNaN(total)) {
+            console.error(
+                'Total from response is not a number. Please check your dataProvider or the API.'
+            );
+        } else {
+            setState({
+                ...state,
+                data,
+                total,
+                loaded: true,
+            });
+        }
     }
     const dataProvider = useDataProvider();
     useEffect(() => {