Renamed shadowed variable, removed useless argument and factorize cases

marmelab · Oct 10, 2019 · 291ba32 · 291ba32
1 parent 7975de5
commit 291ba32
Showing 1 changed file with 7 additions and 17 deletions.
diff --git a/packages/ra-data-graphql-simple/src/buildVariables.js b/packages/ra-data-graphql-simple/src/buildVariables.js
@@ -89,7 +89,7 @@ const prepareParams = (params, queryType, introspectionResults) => {
             return;
         }
 
-        result[key] = castType(param, arg.type, introspectionResults.types);
+        result[key] = castType(param, arg.type);
     });
 
     return result;
@@ -115,8 +115,8 @@ const buildGetListVariables = introspectionResults => (
 
             if (filterSome) {
                 const filter = Object.keys(params.filter[key]).reduce(
-                    (acc, k) => ({
-                        ...acc,
+                    (filter_acc, k) => ({
+                        ...filter_acc,
                         [`${k}_in`]: params.filter[key][k],
                     }),
                     {}
@@ -185,7 +185,7 @@ const buildGetListVariables = introspectionResults => (
     };
 };
 
-const buildCreateUpdateVariables = () => (
+const buildCreateUpdateVariables = (
     resource,
     aorFetchType,
     params,
@@ -256,28 +256,18 @@ export default introspectionResults => (
             };
         }
         case GET_ONE:
+        case DELETE:
             return {
                 id: preparedParams.id,
             };
+        case CREATE:
         case UPDATE: {
-            return buildCreateUpdateVariables(introspectionResults)(
-                resource,
-                aorFetchType,
-                preparedParams,
-                queryType
-            );
-        }
-        case CREATE: {
-            return buildCreateUpdateVariables(introspectionResults)(
+            return buildCreateUpdateVariables(
                 resource,
                 aorFetchType,
                 preparedParams,
                 queryType
             );
         }
-        case DELETE:
-            return {
-                id: preparedParams.id,
-            };
     }
 };