This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
fix reference to Material UI #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
commented
Jul 7, 2023
| <span class="text-center">React</span> | ||
| </li> | ||
| <li class="flex flex-col items-center justify-end"> | ||
| <img src="./material-ui.png" alt="MUI" /> | ||
| <span class="text-center">MUI</span> | ||
| <img src="./material-ui.png" alt="" /> |
There was a problem hiding this comment.
Fix an a11y issue, this is a decorative image, it must have an empty alt, https://www.w3.org/WAI/tutorials/images/decorative/
| <img src="./typescript.png" alt="Typescript" /> | ||
| <span class="text-center">Typescript</span> | ||
| <img src="./typescript.png" alt="" /> | ||
| <span class="text-center">TypeScript</span> |
| @@ -278,7 +278,7 @@ | |||
| };</code | |||
| ></pre> | |||
| <img | |||
| src="./Screen_ee.png" | |||
| src="./screen_ee.png" | |||
There was a problem hiding this comment.
The upper case is inconsistent with the other image. Also since only Linux is case-sensitive, this creates problems on macOS and Windows.
|
Thanks for the PR 👍 However this repo actually contains an old version of the landing pages (it was used as a draft). The current version is here: https://github.com/marmelab/react-admin/tree/gh-pages/landing-page Could you change the PR to target this repo/branch/folder instead? Thank you so much |
|
ok, I'm moving this marmelab/react-admin#9096 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as algolia/docsearch#1953