Skip to content

Commit

Permalink
qubes/vm: do not recursively use repr in BaseVM.__repr__
Browse files Browse the repository at this point in the history
This will easily end up in infinite recursion. For example
'sys-net'.template points at 'fedora-23', which itself has
'fedora-23'.netvm set to 'sys-net'.
  • Loading branch information
marmarek committed Mar 7, 2016
1 parent bcc785d commit c828b64
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion qubes/vm/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def __repr__(self):
proprepr = []
for prop in self.property_list():
try:
proprepr.append('{}={!r}'.format(
proprepr.append('{}={!s}'.format(
prop.__name__, getattr(self, prop.__name__)))
except AttributeError:
continue
Expand Down

0 comments on commit c828b64

Please sign in to comment.