Add status and method in calendar event #300
Conversation
giuseppenucifora
commented
Jul 5, 2021
giuseppenucifora
commented
- Add status property in Event
- Add method property in Event
|
Hey Giuseppe, thanks for your contribution. There are some problem that needs to be solved before I can merge this pull request:
|
| @@ -111,7 +113,7 @@ protected function getProperties(Event $event): Generator | |||
| protected function getComponents(Event $event): Generator | |||
| { | |||
| yield from array_map( | |||
| fn (Alarm $alarm) => $this->alarmFactory->createComponent($alarm), | |||
There was a problem hiding this comment.
The code style was changed here. That is one of the reasons, why the CI pipeline fails.
You can fix the code style by running make fix locally.
|
@markuspoerschke as you rightly suggested, I refactor the code by adding two enum for method and status but now launching test , the phpmd test gave this error :
can you help me to solve? Scuse me, but unfortunately i don't know this. :) |
- Add method property in Event - Update Unit test to test new properties
giuseppenucifora
force-pushed
the
feature/event-status-and-method
branch
from
f1673ae
to
ba81b43
Compare
This is a violated rule from PHPMD. Since the Factory class will assemble a lot of properties, I think we can ignore the error message. You could add a |
…nt (markuspoerschke#302) * remove PHP-CS-Cache v3 with make clean * dont use phony target for composer dependencies: don't install composer dependencies if already installed this will speedup `make test` locally * dont install node_modules if present when `make fix-prettier` is called
Change MethodType enum tu Method Add @SuppressWarnings("PHPMD.NPathComplexity") in getProperties function of EventFactory class Add @SuppressWarnings("PHPMD.CyclomaticComplexity") in getProperties function of EventFactory class
