fix review comments

markusahlstrand · Dec 16, 2024 · 4430ec4 · 4430ec4
1 parent 5db636b
commit 4430ec4
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 354 deletions.
diff --git a/packages/authhero/src/emails/index.ts b/packages/authhero/src/emails/index.ts
@@ -16,7 +16,7 @@ export async function sendEmail(
     throw new HTTPException(500, { message: "Email provider not found" });
   }
 
-  const emailService = ctx.env.emailProvders?.[emailProvider.name];
+  const emailService = ctx.env.emailProviders?.[emailProvider.name];
   if (!emailService) {
     throw new HTTPException(500, { message: "Email provider not found" });
   }

diff --git a/packages/authhero/src/emails/templates/password-reset.ts b/packages/authhero/src/emails/templates/password-reset.ts
diff --git a/packages/authhero/src/routes/auth-api/dbconnections.ts b/packages/authhero/src/routes/auth-api/dbconnections.ts
@@ -104,9 +104,10 @@ export const dbConnectionRoutes = new OpenAPIHono<{
       ctx.set("connection", newUser.connection);
 
       // Store the password
+      const hashedPassword = await bcryptjs.hash(password, 10);
       await ctx.env.data.passwords.create(client.tenant.id, {
         user_id: newUser.user_id,
-        password: bcryptjs.hashSync(password, 10),
+        password: hashedPassword,
         algorithm: "bcrypt",
       });
 

diff --git a/packages/authhero/src/types/Bindings.ts b/packages/authhero/src/types/Bindings.ts
@@ -18,7 +18,7 @@ export type Bindings = {
   hooks?: {
     onExecuteCredentialsExchange?: OnExecuteCredentialsExchange;
   };
-  emailProvders?: { [key: string]: EmailService };
+  emailProviders?: { [key: string]: EmailService };
 
   // Constants
   JWKS_CACHE_TIMEOUT_IN_SECONDS: number;

diff --git a/packages/authhero/test/helpers/test-server.ts b/packages/authhero/test/helpers/test-server.ts
@@ -85,7 +85,7 @@ export async function getTestServer(args: getEnvParams = {}) {
 
   const env: Bindings = {
     data,
-    emailProvders: {
+    emailProviders: {
       "mock-email": mockEmailService.sendEmail.bind(mockEmailService),
     },
     JWKS_SERVICE: {