Skip to content

Commit

Permalink
fix: test fixes for new harnesses
Browse files Browse the repository at this point in the history
  • Loading branch information
@markuczy
markuczy committed Apr 3, 2024
1 parent c19eecf commit de67a0e
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 57 deletions.
86 changes: 38 additions & 48 deletions libs/angular-accelerator/src/lib/components/page-header/page-header.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const mockActions: Action[] = [
},
]

describe('PageHeaderComponent', () => {
fdescribe('PageHeaderComponent', () => {
const origAddEventListener = window.addEventListener
const origPostMessage = window.postMessage

Expand Down Expand Up @@ -115,13 +115,14 @@ describe('PageHeaderComponent', () => {

it('should check permissions and render buttons accordingly', async () => {
expect(await pageHeaderHarness.getInlineActionButtons()).toHaveLength(0)
expect(await pageHeaderHarness.getOverflowActionButtons()).toHaveLength(0)
expect(await pageHeaderHarness.getOverflowActionButton()).toBeNull()

component.actions = mockActions

expect(await pageHeaderHarness.getInlineActionButtons()).toHaveLength(1)
expect(await pageHeaderHarness.getElementByTitle('My Test Action')).toBeTruthy()
expect(await pageHeaderHarness.getOverflowActionButtons()).toHaveLength(1)
await (await pageHeaderHarness.getOverflowActionButton())?.click()
expect(await pageHeaderHarness.getOverFlowMenuItems()).toHaveLength(2)
expect(await pageHeaderHarness.getElementByTitle('More actions')).toBeTruthy()
expect(userServiceSpy).toHaveBeenCalledTimes(3)
})
Expand All @@ -132,13 +133,13 @@ describe('PageHeaderComponent', () => {
userServiceSpy.mockReturnValue(false)

expect(await pageHeaderHarness.getInlineActionButtons()).toHaveLength(0)
expect(await pageHeaderHarness.getOverflowActionButtons()).toHaveLength(0)
expect(await pageHeaderHarness.getOverflowActionButton()).toBeNull()

component.actions = mockActions

expect(await pageHeaderHarness.getInlineActionButtons()).toHaveLength(0)
expect(await pageHeaderHarness.getElementByTitle('My Test Action')).toBeFalsy()
expect(await pageHeaderHarness.getOverflowActionButtons()).toHaveLength(0)
expect(await pageHeaderHarness.getOverFlowMenuItems()).toHaveLength(0)
expect(await pageHeaderHarness.getElementByTitle('More actions')).toBeFalsy()
expect(userServiceSpy).toHaveBeenCalledTimes(3)
})
Expand All @@ -159,20 +160,15 @@ describe('PageHeaderComponent', () => {
component.objectDetails = objectDetailsWithoutIcons

expect((await pageHeaderHarness.getObjectInfos()).length).toEqual(2)
const objectDetailLabels = await pageHeaderHarness.getObjectDetailLabels()
const objectDetailValues = await pageHeaderHarness.getObjectDetailValues()
const objectDetailIcons = await pageHeaderHarness.getObjectDetailIcons()
expect(objectDetailLabels.length).toEqual(2)
expect(objectDetailValues.length).toEqual(2)
expect(objectDetailIcons.length).toEqual(0)

objectDetailLabels.forEach(async (label, i) => {
expect(await label.text()).toEqual(objectDetailsWithoutIcons[i].label)
})

objectDetailValues.forEach(async (value, i) => {
expect(await value.text()).toEqual(objectDetailsWithoutIcons[i].value)
})
const firstDetail = await pageHeaderHarness.getObjectInfoByLabel('Venue')
expect(await firstDetail?.getLabel()).toEqual('Venue')
expect(await firstDetail?.getValue()).toEqual('AIE Munich')
expect(await firstDetail?.getIcon()).toBeUndefined()
const secondDetail = await pageHeaderHarness.getObjectInfoByLabel('Status')
expect(await secondDetail?.getLabel()).toEqual('Status')
expect(await secondDetail?.getValue()).toEqual('Confirmed')
expect(await secondDetail?.getIcon()).toBeUndefined()
})

it('should render objectDetails with icons as object info in the page header', async () => {
Expand All @@ -199,35 +195,31 @@ describe('PageHeaderComponent', () => {
component.objectDetails = objectDetailsWithIcons

expect((await pageHeaderHarness.getObjectInfos()).length).toEqual(4)
const objectDetailLabels = await pageHeaderHarness.getObjectDetailLabels()
const objectDetailValues = await pageHeaderHarness.getObjectDetailValues()
const objectDetailIcons = await pageHeaderHarness.getObjectDetailIcons()
expect(objectDetailLabels.length).toEqual(4)
expect(objectDetailValues.length).toEqual(3)
expect(objectDetailIcons.length).toEqual(2)

objectDetailLabels.forEach(async (label, i) => {
expect(await label.text()).toEqual(objectDetailsWithIcons[i].label)
})

objectDetailValues.forEach(async (value, i) => {
if (objectDetailsWithIcons[i].value) {
expect(await value.text()).toEqual(objectDetailsWithIcons[i].value)
}
})

expect(await objectDetailIcons[0].getAttribute('class')).toEqual(objectDetailsWithIcons[1].icon)
expect(await objectDetailIcons[1].getAttribute('class')).toEqual(objectDetailsWithIcons[2].icon)
const firstDetail = await pageHeaderHarness.getObjectInfoByLabel('Venue')
expect(await firstDetail?.getLabel()).toEqual('Venue')
expect(await firstDetail?.getValue()).toEqual('AIE Munich')
expect(await firstDetail?.getIcon()).toBeUndefined()
const secondDetail = await pageHeaderHarness.getObjectInfoByLabel('Status')
expect(await secondDetail?.getLabel()).toEqual('Status')
expect(await secondDetail?.getValue()).toEqual('Confirmed')
expect(await secondDetail?.getIcon()).toEqual(PrimeIcons.CHECK)
const thirdDetail = await pageHeaderHarness.getObjectInfoByLabel('Done?')
expect(await thirdDetail?.getLabel()).toEqual('Done?')
expect(await thirdDetail?.getValue()).toEqual('')
expect(await thirdDetail?.getIcon()).toEqual(PrimeIcons.EXCLAMATION_CIRCLE)
const fourthDetail = await pageHeaderHarness.getObjectInfoByLabel('Empty')
expect(await fourthDetail?.getLabel()).toEqual('Empty')
expect(await fourthDetail?.getValue()).toBeUndefined()
expect(await fourthDetail?.getIcon()).toBeUndefined()
})

it('should show overflow actions when menu overflow button clicked', async () => {
component.actions = mockActions

const menuOverflowButtons = await pageHeaderHarness.getOverflowActionButtons()
const menuOverflowButton = await pageHeaderHarness.getOverflowActionButton()

expect(menuOverflowButtons).toBeTruthy()
expect(menuOverflowButtons.length).toBe(1)
await menuOverflowButtons[0].click()
expect(menuOverflowButton).toBeTruthy()
await menuOverflowButton?.click()

const menuItems = await pageHeaderHarness.getOverFlowMenuItems()
expect(menuItems.length).toBe(2)
Expand All @@ -240,11 +232,10 @@ describe('PageHeaderComponent', () => {

component.actions = mockActions

const menuOverflowButtons = await pageHeaderHarness.getOverflowActionButtons()
const menuOverflowButton = await pageHeaderHarness.getOverflowActionButton()

expect(menuOverflowButtons).toBeTruthy()
expect(menuOverflowButtons.length).toBe(1)
await menuOverflowButtons[0].click()
expect(menuOverflowButton).toBeTruthy()
await menuOverflowButton?.click()

const menuItems = await pageHeaderHarness.getOverFlowMenuItems()
expect(menuItems.length).toBe(2)
Expand All @@ -259,10 +250,9 @@ describe('PageHeaderComponent', () => {

component.actions = mockActions

const menuOverflowButton = await pageHeaderHarness.getOverflowActionButtons()
const menuOverflowButton = await pageHeaderHarness.getOverflowActionButton()
expect(menuOverflowButton).toBeTruthy()
expect(menuOverflowButton.length).toBe(1)
menuOverflowButton[0].click()
await menuOverflowButton?.click()

const overFlowMenuItems = await pageHeaderHarness.getOverFlowMenuItems()
const disabledActionElement = overFlowMenuItems[1]
Expand Down
18 changes: 9 additions & 9 deletions libs/angular-accelerator/testing/page-header.harness.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,8 @@ export class PageHeaderHarness extends ComponentHarness {
static hostSelector = 'ocx-page-header'

getPageHeaderWrapperHarness = this.locatorForAll('[name="ocx-page-header-wrapper"]')
getBreadcrumb = this.locatorFor(PBreadcrumbHarness)
getMenu = this.locatorFor(PMenuHarness)

async getOverflowActionButton() {
return await this.locatorFor('[name="ocx-page-header-overflow-action-button"]')()
}
getBreadcrumb = this.locatorForOptional(PBreadcrumbHarness)
getMenu = this.locatorForOptional(PMenuHarness)

async getElementByTitle(title: string) {
return await this.locatorForOptional(`[title="${title}"]`)()
Expand Down Expand Up @@ -48,20 +44,24 @@ export class PageHeaderHarness extends ComponentHarness {
return await this.locatorForOptional(PButtonHarness.with({ icon: buttonIcon }))()
}

async getOverflowActionButton() {
return await this.locatorForOptional('[name="ocx-page-header-overflow-action-button"]')()
}

async getOverFlowMenuItems() {
const menu = await this.getMenu()
const menuItems = await menu.getAllMenuItems()
const menuItems = await menu?.getAllMenuItems()
return menuItems ?? []
}

async getOverFlowMenuItem(itemText: string): Promise<MenuItemHarness | undefined | null> {
const menu = await this.getMenu()
return await menu.getMenuItem(itemText)
return await menu?.getMenuItem(itemText)
}

async getBreadcrumbItem(itemText: string): Promise<ListItemHarness | undefined | null> {
const breadcrumb = await this.getBreadcrumb()
return await breadcrumb.getBreadcrumbItem(itemText)
return await breadcrumb?.getBreadcrumbItem(itemText)
}

async getHeaderText(): Promise<string | undefined> {
Expand Down

0 comments on commit de67a0e

Please sign in to comment.