-
Notifications
You must be signed in to change notification settings - Fork 23
models.BleachField's form field set to forms.BleachField #19
Conversation
models.BleachField form field label set to field's verbose_name
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
===========================================
- Coverage 100.00% 98.75% -1.25%
===========================================
Files 2 3 +1
Lines 49 80 +31
Branches 8 16 +8
===========================================
+ Hits 49 79 +30
- Partials 0 1 +1
Continue to review full report at Codecov.
|
@Alirezaja1384 This needs tests to ensure a model form uses the correct field. Likely best done by updating the form tests to use the bleach form and a new |
Ok, I'll do both soon. |
…e being independent of settings
I have added another test for models.py and its coverage is now 100%. But I have no idea about forms.py. Coverage report says line 35->37 are missed, but there are |
@Alirezaja1384 thank you. The coverage from the github action isn't ran against all files in the app. I raised #20 so that isn't forgotten about. Essentially I need to find some time to look over things 😂👍 |
Description
Describe: models.BleachField's form field automtically set to forms.BleachField in ModelForm
References
Fix #13
Checklist
tox
to ensure tests pass