Added searches, updated natrules, and fixed minor issues with hitcounts and apiclasstemplate #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 8, 2022 11:18
|
Added unit tests |
|
Wow, detailed pull request. Looks great. I'll give it a test on Monday... |
marksull
reviewed
Aug 26, 2022
marksull
reviewed
Aug 26, 2022
Niltak
commented
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added three searches:
globalsearch
object
policy
Fixed issue with how searches work with the current 'get' in apiclasstemplate. Also fixed minor logging issue.
Updated natrules to take nat_id's as well as nat_name. Changed variable from name to nat_name similar to acp.
Added offset to hitcounts to be able to loop hitcounts to grab all rules. Removed pulling items out of the response to keep it consistent with the other classes. *If you want I can add a loop to collect all of the hit count records so that the user doesn't have to build out their own logic.
TODO:
Build out unit_tests