Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix armv6 platform detection #60

Merged
merged 1 commit into from
Feb 5, 2017
Merged

Fix armv6 platform detection #60

merged 1 commit into from
Feb 5, 2017

Conversation

adamantike
Copy link

cls.arch was being overwritten so we never had a armv6 value

@adamantike
Copy link
Author

It would be great if people can test it in armv6 devices! This is the testing build

ping @tatostao, @Panoroma, @rapidnine, @pbouthil, @kidburglar, @andriuski

@andriuski
Copy link

Hi, seems to be not doing much.
kodi.zip

I've attached the log. I ran the test version first and then the latest 1.6.7. After I select 'movies' and click 'latest' and the test version does nothing. The 1.6.7 gets me to actually selecting a movie and then does nothing.

Good luck

@adamantike
Copy link
Author

@andriuski can you please provide me the logs for when you run the 1.6.7 version?

@andriuski
Copy link

Both of them are in the log I've attached: test version first and 1.6.7 after it.

@adamantike
Copy link
Author

The error I'm seeing in your logs (UnboundLocalError: local variable 'trailer' referenced before assignment) was solved in 1.6.1 (commit fefd46c)! Can you please uninstall the addon and install 1.6.7 from scratch? :)

@markop159
Copy link
Owner

@andriuski @adamantike last couple of builds are using ARMv6 binaries so it works on ARMv6 and ARMv7 because ARMv7 is backward compatible.

@andriuski
Copy link

Thanks @markop159
I also have an RPi3 running the same and it works perfectly.

A.

@adamantike
Copy link
Author

@markop159 In that case, I have updated this PR to remove the armv6 detection logic

@markop159
Copy link
Owner

markop159 commented Feb 5, 2017

Yeah tnx I guess I forgot about this and left it there :)

@markop159 markop159 merged commit ff9057b into markop159:master Feb 5, 2017
@adamantike adamantike deleted the fix-armv6-detection branch February 5, 2017 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants