fix: child tag name analysis (#2372)

marko-js · Nov 21, 2024 · 2fa5df5 · 2fa5df5
1 parent b511096
commit 2fa5df5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/.changeset/curvy-boxes-fry.md b/.changeset/curvy-boxes-fry.md
@@ -0,0 +1,5 @@
+---
+"@marko/translator-tags": patch
+---
+
+Ensure tag name type analysis only returns a custom tag when we can perform child template analysis.
diff --git a/packages/translator-tags/src/util/tag-name-type.ts b/packages/translator-tags/src/util/tag-name-type.ts
@@ -56,14 +56,6 @@ export default function analyzeTagNameType(tag: t.NodePath<t.MarkoTag>) {
             referencedBindings: bindingIdentifier.extra?.binding,
           };
           analyzeExpressionTagName(name.replaceWith(tagIdentifier)[0], extra);
-        } else {
-          const childFile = loadFileForTag(tag);
-          if (!childFile) {
-            extra.tagNameType = TagNameType.DynamicTag;
-          } else if (childFile.ast.program.extra!.featureType === "class") {
-            extra.tagNameType = TagNameType.DynamicTag;
-            extra.featureType = "class";
-          }
         }
       }
 
@@ -78,6 +70,16 @@ export default function analyzeTagNameType(tag: t.NodePath<t.MarkoTag>) {
     if (extra.tagNameType === undefined) {
       extra.tagNameType = TagNameType.DynamicTag;
     }
+
+    if (extra.tagNameType === TagNameType.CustomTag) {
+      const childFile = loadFileForTag(tag);
+      if (!childFile) {
+        extra.tagNameType = TagNameType.DynamicTag;
+      } else if (childFile.ast.program.extra!.featureType === "class") {
+        extra.tagNameType = TagNameType.DynamicTag;
+        extra.featureType = "class";
+      }
+    }
   }
 
   return extra.tagNameType;