Skip to content

Commit

Permalink
Add constraints and requirements for unit/integration tests consisten…
Browse files Browse the repository at this point in the history
…t with the minimum versions of the AWS SDK we explicitly state we support
  • Loading branch information
tremble committed Sep 16, 2021
1 parent 8025686 commit 0a9551d
Show file tree
Hide file tree
Showing 7 changed files with 43 additions and 7 deletions.
4 changes: 4 additions & 0 deletions bindep.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Needed for generating EC2 format fingerprints
openssl [test platform:rpm]
gcc [test platform:rpm]
python3-devel [test platform:rpm]
7 changes: 6 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
boto>=2.49.0
# When updating the minimal requirements please also update
# - tests/unit/constraints.txt
# - tests/integration/constraints.txt
# - tests/integration/targets/setup_botocore_pip
botocore>=1.18.0
boto3>=1.15.0
# Final released version
boto>=2.49.0
6 changes: 6 additions & 0 deletions test-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
botocore
boto3
boto

coverage==4.5.4
placebo
mock
Expand All @@ -8,3 +12,5 @@ pytest-mock
netaddr
# Sometimes needed where we don't have features we need in modules
awscli
# Used for comparing SSH Public keys to the Amazon fingerprints
pycrypto
8 changes: 6 additions & 2 deletions tests/integration/constraints.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
boto3 >= 1.9.250, <= 1.15.18 # minimum version that supports botocore 1.13.3, max that will work with ansible 2.9's other constraints
botocore<1.19.0,>=1.13.3 # adds support for ECR image scanning
# Specifically run tests against the oldest versions that we support
boto3==1.15.0
botocore==1.18.0

# AWS CLI has `botocore==` dependencies, provide the one that matches botocore
# to avoid needing to download over a years worth of awscli wheels.
awscli==1.18.141
11 changes: 9 additions & 2 deletions tests/integration/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Our code is based on the AWS SDKs
boto
boto3
botocore

# netaddr is needed for ansible.netcommon.ipv6
netaddr
virtualenv
boto3
botocore
# Sometimes needed where we don't have features we need in modules
awscli
# Used for comparing SSH Public keys to the Amazon fingerprints
pycrypto
7 changes: 7 additions & 0 deletions tests/unit/constraints.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Specifically run tests against the oldest versions that we support
boto3==1.15.0
botocore==1.18.0

# AWS CLI has `botocore==` dependencies, provide the one that matches botocore
# to avoid needing to download over a years worth of awscli wheels.
awscli==1.18.141
7 changes: 5 additions & 2 deletions tests/unit/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Our code is based on the AWS SDKs
botocore
boto3
boto

placebo
botocore>=1.18.0
boto3>=1.15.0

0 comments on commit 0a9551d

Please sign in to comment.