fix(coordinates): edge coordinates now go right up to the axis

There was previously a small gap between the axis and the edge coordinate.
markmcdowell · Oct 8, 2019 · ba44493 · ba44493
1 parent 0223b6b
commit ba44493
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 10 deletions.
diff --git a/packages/charts/src/coordinates/EdgeCoordinateV3.tsx b/packages/charts/src/coordinates/EdgeCoordinateV3.tsx
@@ -266,7 +266,7 @@ export function drawOnCanvas(ctx: CanvasRenderingContext2D, props) {
         } else if (rectRadius) {
             roundRect(ctx, x, y, rectWidth, rectHeight, 3);
         } else {
-            ctx.rect(x + 0.5, y + 0.5, rectWidth, rectHeight);
+            ctx.rect(x - 0.5, y - 0.5, rectWidth, rectHeight);
         }
 
         ctx.fill();

diff --git a/packages/charts/src/coordinates/MouseCoordinateY.tsx b/packages/charts/src/coordinates/MouseCoordinateY.tsx
@@ -56,14 +56,18 @@ export class MouseCoordinateY extends React.Component<MouseCoordinateYProps> {
 
     private readonly renderSVG = (moreProps) => {
         const props = this.helper(this.props, moreProps);
-        if (isNotDefined(props)) { return null; }
+        if (isNotDefined(props)) {
+            return null;
+        }
 
         return renderSVG(props);
     }
 
     private readonly drawOnCanvas = (ctx: CanvasRenderingContext2D, moreProps) => {
         const props = this.helper(this.props, moreProps);
-        if (isNotDefined(props)) { return null; }
+        if (isNotDefined(props)) {
+            return null;
+        }
 
         drawOnCanvas(ctx, props);
     }
@@ -72,11 +76,17 @@ export class MouseCoordinateY extends React.Component<MouseCoordinateYProps> {
         const { chartId } = moreProps;
         const { currentCharts, mouseXY } = moreProps;
 
-        if (isNotDefined(mouseXY)) { return null; }
-        if (currentCharts.indexOf(chartId) < 0) { return null; }
+        if (isNotDefined(mouseXY)) {
+            return null;
+        }
+        if (currentCharts.indexOf(chartId) < 0) {
+            return null;
+        }
 
         const { show } = moreProps;
-        if (!show) { return null; }
+        if (!show) {
+            return null;
+        }
 
         const y = mouseXY[1];
         const { chartConfig: { yScale } } = moreProps;
@@ -113,24 +123,21 @@ export function getYCoordinate(y, displayValue, props, moreProps) {
         hideLine,
         fill,
         opacity,
-
         fontFamily,
         fontSize,
         textFill,
-
         stroke,
         strokeOpacity,
         strokeWidth,
-
         rectWidth,
         rectHeight,
-
         arrowWidth,
         dx,
         x1,
         x2,
         y1: y,
         y2: y,
     };
+
     return coordinateProps;
 }