fix(core): children can be undefined or null

Checking for null children for the chart.
markmcdowell · Aug 27, 2020 · 17aa844 · 17aa844
1 parent 00a5cbe
commit 17aa844
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/core/src/utils/ChartDataUtil.ts b/packages/core/src/utils/ChartDataUtil.ts
@@ -67,7 +67,7 @@ const isChartProps = (props: ChartProps | any | undefined): props is ChartProps
 
 export function getNewChartConfig(innerDimension: any, children: any, existingChartConfig: any[] = []) {
     return React.Children.map(children, (each) => {
-        if (each !== undefined && isChartProps(each.props)) {
+        if (each !== undefined && each !== null && isChartProps(each.props)) {
             const chartProps = {
                 ...Chart.defaultProps,
                 ...each.props,

diff --git a/packages/stories/src/features/axis/Axis.tsx b/packages/stories/src/features/axis/Axis.tsx
@@ -54,9 +54,9 @@ class AxisExample extends React.Component<ChartProps> {
                 xExtents={xExtents}
             >
                 <Chart id={1} yExtents={this.yExtents}>
-                    <CandlestickSeries />
                     <XAxis />
                     <YAxis axisAt={axisAt} {...rest} />
+                    <CandlestickSeries />
                 </Chart>
             </ChartCanvas>
         );