feat: add send timeout if server is not available #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the elastic server ist not available every request blocks execution. Now if the server is not reachable the events get saved in a queue and sent with the next request but with a defined timeout. As long the timeout has not exeeded the target do not try to send the request to the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the elastic server ist not available every request blocks execution. Now if the server is not reachable the events get saved in a queue and sent with the next request but with a defined timeout. As long the timeout has not exeeded the target do not try to send the request to the server.
I added two new properties
MaxQueueItems: limits the max items in queue. Default 1000
SendTimeoutOnFailureInMilliseconds: sets the timeout . Default 10000
I had the problem described in
https://github.com/markmcdowell/NLog.Targets.ElasticSearch/issues/174