Delete user schemas from user schemas database only #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
reviewed
Jan 7, 2019
| @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| zipStoreBase=GRADLE_USER_HOME | |||
| zipStorePath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.1-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-bin.zip | |||
There was a problem hiding this comment.
Did you mean to update this? If so, I would do it via a separate PR with an explanation of why it's being updated.
There was a problem hiding this comment.
com.github.jk1.dependency-license-report" version "1.3" requires at least grade version 3.3
As discussed, upgraded to gradle wrapper version 4.10.2
rjrudin
requested changes
Jan 7, 2019
| if (project.hasProperty("database")) { | ||
| println "Connecting via the App-Services port to database: " + project.property("database") | ||
| return getAppConfig().newAppServicesDatabaseClient(project.property("database")) | ||
| } | ||
| else if (database != null){ |
There was a problem hiding this comment.
I think this should come first - if a client passes in a non-null value, use that. Else, check for the project property. Else, call newDatabaseClient.
There was a problem hiding this comment.
cabc11f changes the proirity of task property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/marklogic/datahub-central/issues/726