Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Migrate Unit Testing issues and wikis to ml-unit-test #886

Open
dmcassel opened this issue Jun 7, 2018 · 4 comments
Open

Migrate Unit Testing issues and wikis to ml-unit-test #886

dmcassel opened this issue Jun 7, 2018 · 4 comments

Comments

@dmcassel
Copy link
Collaborator

dmcassel commented Jun 7, 2018

Roxy's Unit Test Framework has been segmented off to https://github.com/marklogic-community/ml-unit-test. In order to complete that process:

  • copy all testing wikis from Roxy to ml-unit-test and delete them from Roxy's wiki
  • add a wiki pointing to the newer repo
  • copy all Unit Testing issues to ml-unit-test and close them here

Question: should the unit testing code remain here in the Roxy repo? If it's removed, that will cause it to disappear from existing projects that upgrade. If it's left, we may be encouraging further drift.

@grtjn
Copy link
Contributor

grtjn commented Aug 24, 2018

Has anyone tried applying ml-unit-test to a Roxy project? What does it entail? Is it backwards-compatible with the Roxy unit-testing stuff? If it is trivial to upgrade to ml-unit-test, then there is no real worry for drift..

@dmcassel
Copy link
Collaborator Author

There have been some bug fixes and improvements, specifically related to JSON handling.

I'm not aware of anyone having applied ml-unit-test to a Roxy project. The difference would be in deployment; usage is basically the same.

@rhdunn
Copy link
Contributor

rhdunn commented Sep 18, 2018

I have manually applied ml-unit-test to an existing project by copying the test files, not using the ml-gradle deployment or similar. Aside from working out where the files are (ml-unit-test-modules/src/main/ml-modules/root/test), the process has been straightforward, and haven't encountered any issues thus far.

Comparing the base ml-unit-test version (0.9.1) to the Roxy version, it is missing afaac5d (#757 - return a 409 HTTP status code when there are test failures). Other than that, that version looks the same aside from formatting.

@dmcassel
Copy link
Collaborator Author

Just filed an issue to get that 409 enhancement into ml-unit-test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants