Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return http 409 if any tests fail #38

Closed
dmcassel opened this issue Sep 18, 2018 · 2 comments
Closed

return http 409 if any tests fail #38

dmcassel opened this issue Sep 18, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dmcassel
Copy link
Collaborator

This was implemented in Roxy Unit Test. See marklogic-community/roxy@afaac5d.

@rjrudin
Copy link
Contributor

rjrudin commented Aug 9, 2023

I don't think a 4xx is appropriate here, as the caller didn't make any mistakes, and the server didn't encounter any errors in the processing of the request. The call itself completed successfully in terms of running the tests. The fact that a test failed is neither the caller nor the server's fault, it's a natural outcome of the test.

@rjrudin rjrudin closed this as completed Aug 9, 2023
@dmcassel
Copy link
Collaborator Author

dmcassel commented Aug 9, 2023

@rjrudin I agree with your comment. I think I filed this ticket as a difference between ml-unit-test and Roxy, where Geert had made a change to Roxy. But I agree that a failed test isn't a 4xx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants