Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hint for adding "this." to methods and variables #39

Closed
markiewb opened this issue May 30, 2014 · 5 comments
Closed

Add hint for adding "this." to methods and variables #39

markiewb opened this issue May 30, 2014 · 5 comments
Labels
enhancement
Milestone
1.3

Comments

@markiewb
Copy link
Owner

Taken from a request at mailing list

 I want to identify and refactor fields and member functions so that they all have the optional "this." present instead of possibly absent.
markiewb added a commit that referenced this issue May 30, 2014
@markiewb
issue #39: Add hint for adding "this." to methods and variables
6c06a32
markiewb added a commit that referenced this issue May 30, 2014
@markiewb
issue #39: Add hint for adding "this." to methods and variables
b17119a
@markiewb markiewb added this to the 1.3 milestone May 30, 2014
@markiewb
Copy link
Owner Author

Fixed in 1.3

@markiewb
Copy link
Owner Author

markiewb commented Jun 3, 2014

Reopen because of the following Issue: members with this are also matched and transformed
F.e. this.dialog -> this.this.dialog (WRONG)

@markiewb markiewb reopened this Jun 3, 2014
markiewb added a commit that referenced this issue Jun 3, 2014
@markiewb
issue #39: Add hint for adding "this." to methods and variables - fix…
ea3850e 
… issue with this.this
@markiewb
Copy link
Owner Author

markiewb commented Jun 3, 2014

Fixed in 1.3.0.1-SN

@markiewb markiewb closed this as completed Jun 3, 2014
markiewb added a commit that referenced this issue Jun 5, 2014
@markiewb
issue #39: example
25cdeb6
markiewb added a commit that referenced this issue Jun 5, 2014
@markiewb
issue #39: exclude identifier within @annotation, exclude "super" ide…
bbc2884 
…ntifier
markiewb added a commit that referenced this issue Jun 5, 2014
@markiewb
Merge branch 'feature/issue39-otherfixes'
aba08bb 
* feature/issue39-otherfixes:
  issue #39: exclude identifier within @annotation, exclude "super" identifier
  issue #39: example
@markiewb
Copy link
Owner Author

markiewb commented Jun 5, 2014

Issue was reported

I notice it has problems with annotations of a certain type. Just add @SuppressWarnings(value="unchecked") to the member method. It'll get transformed into @SuppressWarnings(this.value="unchecked")
And I've just noticed that the more normal @SuppressWarnings("unchecked") turns into @SuppressWarnings(this."unchecked")
Also "super.member();" gets turned into "this.super().member();" when in a derived class you're trying to call the routine in the base class.

@markiewb markiewb reopened this Jun 5, 2014
@markiewb
Copy link
Owner Author

markiewb commented Jun 5, 2014

Fixed in 1.3.0.2-SN

@markiewb markiewb closed this as completed Jun 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
1 participant
@markiewb