Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal window styling #1

Closed
christopherthomasdesign opened this issue Sep 13, 2018 · 2 comments
Closed

Modal window styling #1

christopherthomasdesign opened this issue Sep 13, 2018 · 2 comments

Comments

@christopherthomasdesign

Started putting the modal window on top of some pages from services, with the shade layer in between. These are quick Sketch mockups so things like the shade styling are a rough approximation of the CSS...

screen shot 2018-09-13 at 13 45 29

Wonder if there will be occasions when the colour is going to clash? Especially on top of blue 'interruptor' sort of screens like you get in passports, Verify etc. Hard to strike the balance between the modal layer having enough contrast and the layer below being visible enough to keep context.

I also think there's something about the way it looks like GOV.UK on top of GOV.UK that might make it look like an ad or spam despite the consistent branding.

Here's the thing @conordelahunty did which looks shaaarp:

screen shot 2018-09-13 at 14 02 25

I think removing the separation of the top black bar makes it look much less like a website on top of another website.

I tried a compromise-ish version which takes our existing button styling and puts it on an all black window. This would make it very unlikely to clash with the layer below.

We pretty much never do things in all black... maybe it looks a bit heavy. But it is heavy cos your application's about to time out so...

screen shot 2018-09-13 at 13 46 21

Thoughts?

markhurrell added a commit that referenced this issue Sep 13, 2018
@markhurrell
Copy link
Owner

markhurrell commented Sep 13, 2018

makes sense to me, have updated the design
fc99fc3

@soniaturcotte
Copy link

I really like the all black version, but we'd have to be pretty rigid on how much content is allowed inside. Anthing more than a short sentence or two will be intense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants