Add timeout to RenderServer.render() #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a configurable timeout to the `render` method signature within `RenderServer`. This defaults to 10 seconds; 5 for sending the request and 5 for reading the response.
cburmeister
force-pushed
the
render-timeout
branch
from
d84b848 to
44186cb
Compare
|
Minor styling nit-picks aside (I'm not outrageously fond of PEP8 line-width), looks good 😄 Thanks for the PR. I'll cut a new release for PyPI. |
|
I've pushed Thanks again for the PR! |
|
@markfinger thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a configurable timeout to the
rendermethod signaturewithin
RenderServer. This defaults to 10 seconds; 5 for sending therequest and 5 for reading the response.