Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kill SIGINT signal at man for marked --help #3483

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: kill SIGINT signal at man for marked --help #3483

merged 1 commit into from
Oct 15, 2024

Conversation

NOMADE55
Copy link
Contributor

Marked version:

v14.1.2

Markdown flavor: n/a

Description

Doing a Ctrl + C (^C ) caused an error on the child process spawned by marked.
The fix was to forward the signal and kill it in the spawned process.

Sorry for the silliest oopsie at #3482

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 2:10pm

UziTech
UziTech requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 💯. Looks like linter is failing. Once that is fixed we can merge this

@NOMADE55
Copy link
Contributor Author

Yeah, sorry for that. I'll fix on Sunday and push!

@NOMADE55 NOMADE55 requested a review from UziTech October 14, 2024 14:11
@UziTech UziTech merged commit b1fd3ea into markedjs:master Oct 15, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
@semantic-release-bot
chore(release): 14.1.3 [skip ci]
4359a62 
## [14.1.3](v14.1.2...v14.1.3) (2024-10-15)

### Bug Fixes

* include single nested parens in emStrong link mask ([#3475](#3475)) ([2b7efa8](2b7efa8))
* kill SIGINT signal at man for marked --help ([#3483](#3483)) ([b1fd3ea](b1fd3ea))
@NOMADE55 NOMADE55 deleted the fix-sigint-at-help branch October 29, 2024 14:10
@akanchhaS akanchhaS mentioned this pull request Nov 6, 2024
Open
@k1rk k1rk mentioned this pull request Nov 7, 2024
Open
This was referenced Nov 7, 2024
Open
Open
@pelletier197 pelletier197 mentioned this pull request Nov 8, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Nov 10, 2024
Open
@WontonSam WontonSam mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Marked CLI] ^C causes manpage error
2 participants
@NOMADE55 @UziTech