Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix unexpected setext heading #2986

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix: fix unexpected setext heading #2986

merged 1 commit into from
Sep 15, 2023

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Sep 14, 2023 •
edited
Loading

Marked version: 9.0.0

Description

Fix setext heading being created when a blank line has spaces.

demo

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Sep 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 9:45pm

@UziTech UziTech merged commit bcc3067 into markedjs:master Sep 15, 2023
10 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 15, 2023
@semantic-release-bot
chore(release): 9.0.1 [skip ci]
56cee0a 
## [9.0.1](v9.0.0...v9.0.1) (2023-09-15)

### Bug Fixes

* fix unexpected setext heading ([#2986](#2986)) ([bcc3067](bcc3067))
* single column table ([#2985](#2985)) ([0743d4a](0743d4a))
@UziTech UziTech deleted the setext-blankline branch September 16, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

@joshbruce joshbruce Awaiting requested review from joshbruce

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blank lines with spaces can render unexpected setext headers
2 participants
@UziTech @styfle