Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore async: false when async: true is set by an extension #2920

Merged
merged 2 commits into from
Aug 19, 2023
Merged

fix: ignore async: false when async: true is set by an extension #2920

merged 2 commits into from
Aug 19, 2023

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Aug 6, 2023

Marked version: 6.0.0

Description

When async: true is set by an extension we need to make sure marked.parse returns a promise to await the extension. If the user passes async: false to the marked.parse function as a second argument we want to warn them that marked will ignore that option and continue to return a Promise.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Aug 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2023 10:23pm

@UziTech UziTech changed the title warn about async false being ignored fix: ignore async: false when async: true is set by an extension Aug 19, 2023
@UziTech UziTech merged commit b6ee877 into markedjs:master Aug 19, 2023
10 checks passed
@UziTech UziTech deleted the async-error branch August 19, 2023 22:58
github-actions bot pushed a commit that referenced this pull request Aug 19, 2023
@semantic-release-bot
chore(release): 7.0.4 [skip ci]
f2a6368 
## [7.0.4](v7.0.3...v7.0.4) (2023-08-19)

### Bug Fixes

* fix more types ([#2893](#2893)) ([a990c54](a990c54))
* ignore async: false when async: true is set by an extension ([#2920](#2920)) ([b6ee877](b6ee877))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

@joshbruce joshbruce Awaiting requested review from joshbruce

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async and hooks extensions not working together
2 participants
@UziTech @styfle