fix: noImplicitAny: true #2891
Merged
fix: noImplicitAny: true #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
styfle
reviewed
Jul 30, 2023
styfle
reviewed
Jul 31, 2023
styfle
reviewed
Aug 1, 2023
styfle
reviewed
Aug 1, 2023
styfle
reviewed
Aug 1, 2023
styfle
reviewed
Aug 1, 2023
styfle
reviewed
Aug 1, 2023
styfle
reviewed
Aug 1, 2023
| preprocess: (markdown: string) => string, | ||
| postprocess: (html: string | undefined) => string | undefined, | ||
| preprocess: (markdown: string) => string | Promise<string>, | ||
| postprocess: (html: string) => string | Promise<string>, |
There was a problem hiding this comment.
Can we remove Promise<string> from preprocess/postprocess now?
There was a problem hiding this comment.
The hooks can return promises if async option is true
https://github.com/markedjs/marked/blob/master/src/Instance.ts#L326
There was a problem hiding this comment.
Hmm, then we might need to overload the types in order to avoid all the as string in src/Instance.ts
styfle
approved these changes
Aug 2, 2023
|
@calculuschild any issue with merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
noImplicitAny: falsefrom tsconfigContributor
Committer
In most cases, this should be a different person than the contributor.