fix: fix multiline setext headings #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Any objections to merging this? |
calculuschild
approved these changes
Nov 19, 2022
styfle
approved these changes
Nov 20, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2022
## [4.2.3](v4.2.2...v4.2.3) (2022-11-20) ### Bug Fixes * fix entity specs ([#2652](#2652)) ([36a2b63](36a2b63)) * fix link reference definitions specs ([#2654](#2654)) ([b7eea95](b7eea95)) * fix marked.use with multiple args ([#2651](#2651)) ([73a7bf5](73a7bf5)) * fix multiline setext headings ([#2655](#2655)) ([4aee878](4aee878))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 4.2.2
Description
Allow multiline setext headings. This fixes 3
Setext headingsspec tests but breaks one test that was only passing because we didn't allow multiline setext headings.The last setext heading test will actually have to be fixed in the blockquote tokenizer.
There was also one unit test that was wrong so I just deleted it. There are other tests that prevent the same regression.
Contributor
Committer
In most cases, this should be a different person than the contributor.