Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select option in demo mode to choose Marked version #1415

Merged
merged 6 commits into from
Feb 17, 2019
Merged

Add select option in demo mode to choose Marked version #1415

merged 6 commits into from
Feb 17, 2019

Conversation

remyhunt
Copy link
Contributor

@remyhunt remyhunt commented Feb 8, 2019

Demo selector Enhancement requested in #1406

@styfle can you please take a look and please help me understand what the Snyk issue might be?

@UziTech
Copy link
Member

UziTech commented Feb 8, 2019

The snyk issue is not related to your PR

@UziTech
Copy link
Member

UziTech commented Feb 8, 2019

This doesn't seem to work. How have you tested it?

@styfle
Copy link
Member

styfle commented Feb 8, 2019

Can you dynamically load the version selector instead of hard code? We don’t want to have to update this code every time we release a new version.

You can find published versions here:

https://registry.npmjs.com/marked

@UziTech
Copy link
Member

UziTech commented Feb 9, 2019

https://github.com/remyhunt/marked/pull/1/ should work.

You can check it out here

Change the version to 0.6.0 and the ids will use slugger to prevent collisions

@UziTech UziTech mentioned this pull request Feb 13, 2019
4 tasks
@styfle styfle added the category: docs Documentation changes label Feb 15, 2019
@UziTech UziTech merged commit bf0399b into markedjs:master Feb 17, 2019
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
…version

Add select option in demo mode to choose Marked version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants