Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inline code regex #1337

Merged
merged 2 commits into from
Sep 20, 2018
Merged

fix inline code regex #1337

merged 2 commits into from
Sep 20, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Sep 16, 2018 •
edited by styfle
Loading

Marked version: 0.5.0

Description

  • Fix inline code trimming

fixes #1218

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styfle
Copy link
Member

styfle commented Sep 16, 2018

Which issue is this fixing?
Or is this just something you noticed recently?

@UziTech
Copy link
Member Author

UziTech commented Sep 16, 2018

The slack issue

@styfle styfle requested a review from davisjam September 16, 2018 20:40
styfle
styfle approved these changes Sep 16, 2018
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davisjam
Copy link
Contributor

davisjam commented Sep 16, 2018 •
edited
Loading

I'm not confident that this change will address the Slack issue. I will ponder it tomorrow.

@UziTech
Copy link
Member Author

UziTech commented Sep 16, 2018

When I tested this change the POC went from 9s to a few ms

@davisjam
Copy link
Contributor

@UziTech Acknowledged. I am thinking about whether variations will still lead to the problem.

@UziTech
Copy link
Member Author

UziTech commented Sep 17, 2018

I updated the regex to pass more of the code span spec. @davisjam check if the new regex is safe.

@UziTech UziTech mentioned this pull request Sep 18, 2018
Closed
@styfle styfle mentioned this pull request Sep 18, 2018
Merged
1 task
Feder1co5oave added a commit to Feder1co5oave/marktex that referenced this pull request Sep 18, 2018
@Feder1co5oave
add tests from markedjs#1307, markedjs#1327, and markedjs#1337
51e97fd
@UziTech
Copy link
Member Author

UziTech commented Sep 18, 2018

I rebased and fixed the merge conflicts after #1338

@davisjam
Copy link
Contributor

I have reviewed the regexes. LGTM.

@styfle styfle merged commit b891696 into markedjs:master Sep 20, 2018
@joshbruce
Copy link
Member

Releasing

@UziTech
Copy link
Member Author

UziTech commented Sep 23, 2018

@joshbruce I really think we should merge #1331 before a new release

@joshbruce
Copy link
Member

Oh. I thought it was already merged. Still good to go, yeah? (From 17 days ago, my bad.)

@UziTech
Copy link
Member Author

UziTech commented Sep 23, 2018

Yup should be good to go

@styfle styfle mentioned this pull request Sep 24, 2018
Merged
12 tasks
@UziTech UziTech deleted the code-trimmed branch February 19, 2019 20:12
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@moamed-syed moamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivate ManPrivate mentioned this pull request Oct 27, 2024
Open
@tdsnyk tdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankari sri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931 mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25 sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtm Latha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDAN GOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024 Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiya ThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Upender5119 Upender5119 mentioned this pull request Oct 30, 2024
Open
@Suriya0802 Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12 Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007 Magali0007 mentioned this pull request Oct 31, 2024
Open
@sureshrtech1 sureshrtech1 mentioned this pull request Oct 31, 2024
Open
@Praganya03 Praganya03 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349 Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@robertnorrie robertnorrie mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnan sinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manohar krithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55 SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-ra swathi-ra mentioned this pull request Nov 2, 2024
Open
@austinskou austinskou mentioned this pull request Nov 3, 2024
Open
@BD-HUGO BD-HUGO mentioned this pull request Nov 3, 2024
Open
@danielsb74 danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26 selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldev merkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-git joedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-Snyk MimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKo BenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisjam davisjam davisjam approved these changes

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
category: code blocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code blocks with email-like text are no longer parsed as code
4 participants
@UziTech @styfle @davisjam @joshbruce