Avoid declaring the same variable twice. #1028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src is an argument to Lexer.prototype.token so there is no need to declare it as a variable. It doesn’t seem to do any harm, but some linters/compilers (read: Closure Compiler) complain. Since there’s almost zero cost in getting rid of the duplicate declaration, do so.
|
LGTM. Second pair of eyes, please: @Feder1co5oave or @UziTech. |
|
Yep. I fixed this in #1020 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src is an argument to Lexer.prototype.token so there is no need to
declare it as a variable. It doesn’t seem to do any harm, but some
linters/compilers (read: Closure Compiler) complain. Since there’s
almost zero cost in getting rid of the duplicate declaration, do so.