add html test to heading ids

markedjs · Mar 20, 2020 · 7330a9c · 7330a9c
1 parent f01ba94
commit 7330a9c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/Slugger.js b/src/Slugger.js
@@ -13,6 +13,9 @@ module.exports = class Slugger {
     let slug = value
       .toLowerCase()
       .trim()
+      // remove html tags
+      .replace(/<!?\/?[\w-]+(?: .*)?\/?>/g, '')
+      // remove unwanted chars
       .replace(/[\u2000-\u206F\u2E00-\u2E7F\\'!"#$%&()*+,./:;<=>?@[\]^`{|}~]/g, '')
       .replace(/\s/g, '-');
 

diff --git a/test/specs/new/headings_id.html b/test/specs/new/headings_id.html
@@ -1,3 +1,5 @@
+<h3 id="heading-with-html">Heading with <em>html</em></h3>
+
 <h3 id="heading-with-a-link">Heading with a <a href="http://github.com/">link</a></h3>
 
 <h3 id="heading-with-some-italic-text">Heading with some <em>italic text</em></h3>
@@ -10,4 +12,4 @@ <h3 id="or-even-code">Or even <code>code</code></h3>
 
 <h3 id="what-about-strikethrough">What about <del>strikethrough</del></h3>
 
-<h2 id="and-a-ref-link">And a ref <a href="/some/url" title="link to nowhere">link</a></h2>
+<h2 id="and-a-ref-link">And a ref <a href="/some/url" title="link to nowhere">link</a></h2>
diff --git a/test/specs/new/headings_id.md b/test/specs/new/headings_id.md
@@ -1,3 +1,5 @@
+### Heading with <em>html</em>
+
 ### Heading with a [link](http://github.com/)
 
 ### Heading with some _italic text_
@@ -11,4 +13,4 @@
 
 ## And a ref [link][destination]
 
-[destination]: /some/url "link to nowhere"
+[destination]: /some/url "link to nowhere"