Extended text filter functionality to allow precise filtering of speech, Razor overhead messages and sys messages #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 4, 2022 22:04
Also fixed bug with overhead messages not working on messages that got repeat filtered
|
I'm finished with the implementation now. Debugged and tested it as much as I could on Outlands and had no more issues. It also fixed a previous bug where overhead messages would not be registered if the sys message was filtered by the "filter repeated system messages" option. The new edit form for filter options is still a bit choppy, it looks good in the designer but not when I run it. But that's just aesthetics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the text filter option under Filters -> Text & Messages only filters speech.
With this PR, players would be able to decide where the text should be filtered on:
For system messages, they can additionally decide if the filtered messages should still trigger overhead messages and be found via the "insysmsg" script expression.
The change is backwards compatible so players using the speech filter already won't notice any changes.