This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rumperuu
added
documentation
Improvements or additions to documentation
workflow
Workflow improvements
labels
Apr 25, 2021
markcheret
reviewed
Apr 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the pre-commit hook deleted?
It should have been done as part of #143, which replaced the custom pre-commit hook with Husky and |
lolzim
approved these changes
Apr 25, 2021
markcheret
approved these changes
Apr 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.7.2 has been released to the SVN - it is the same as 2.7.1 but released with the correct stylesheets this time. I've tested and verified that it's all gone through correctly
This PR just reflects that on the GitHub repo.
The usual testing and review process was not necessary as we had already gone through it for the 2.7.1 release, which was recalled only because the process wrongly packaged it with outdated stylesheets (see #104 (reply in thread)). Also, whilst the Stable Tag field was downgraded to 2.7.0 quickly, we know from experience that some people have enabled automatic Plugin updates and WP does not automatically handle downgrades, so this release will ensure that everything is fixed for them.
Update
2.7.2 resulted in fatal errors on some sites (see here and here). This wasn't detected during testing because on both of my test sites, the error only occurred when accessing the WYSIWYG editor and did not result in the site being inaccessible, whereas these users evidently had their sites set up to fail completely on fatal errors no matter where they occurred.
I had to go outside of the normal release process in order to push 2.7.3 urgently and fix the issue. This PR now brings the GitHub repo. up-to-date with that version.
I'm not touching releases again until 2.8.0 is done 😷