Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

release: release 2.7.3 #144

Merged
merged 7 commits into from
Apr 25, 2021
Merged

release: release 2.7.3 #144

merged 7 commits into from
Apr 25, 2021

Conversation

Rumperuu
Copy link
Collaborator

@Rumperuu Rumperuu commented Apr 25, 2021

2.7.2 has been released to the SVN - it is the same as 2.7.1 but released with the correct stylesheets this time. I've tested and verified that it's all gone through correctly

This PR just reflects that on the GitHub repo.

The usual testing and review process was not necessary as we had already gone through it for the 2.7.1 release, which was recalled only because the process wrongly packaged it with outdated stylesheets (see #104 (reply in thread)). Also, whilst the Stable Tag field was downgraded to 2.7.0 quickly, we know from experience that some people have enabled automatic Plugin updates and WP does not automatically handle downgrades, so this release will ensure that everything is fixed for them.

Update

2.7.2 resulted in fatal errors on some sites (see here and here). This wasn't detected during testing because on both of my test sites, the error only occurred when accessing the WYSIWYG editor and did not result in the site being inaccessible, whereas these users evidently had their sites set up to fail completely on fatal errors no matter where they occurred.

I had to go outside of the normal release process in order to push 2.7.3 urgently and fix the issue. This PR now brings the GitHub repo. up-to-date with that version.

I'm not touching releases again until 2.8.0 is done 😷

@Rumperuu Rumperuu added documentation Improvements or additions to documentation workflow Workflow improvements labels Apr 25, 2021
@Rumperuu Rumperuu added this to the 2.7.1 milestone Apr 25, 2021
@Rumperuu Rumperuu requested review from markcheret and lolzim April 25, 2021 11:47
@Rumperuu Rumperuu self-assigned this Apr 25, 2021
@Rumperuu Rumperuu changed the title release: release 2.7.2 release: release 2.7.3 Apr 25, 2021
Copy link
Owner

@markcheret markcheret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the pre-commit hook deleted?

@Rumperuu
Copy link
Collaborator Author

Why was the pre-commit hook deleted?

It should have been done as part of #143, which replaced the custom pre-commit hook with Husky and lint-staged (which makes it a lot easier to juggle various pre-x hooks)

@Rumperuu Rumperuu requested a review from markcheret April 25, 2021 19:20
Copy link
Owner

@markcheret markcheret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Rumperuu Rumperuu merged commit ac81903 into main Apr 25, 2021
@Rumperuu Rumperuu deleted the release-2.7.2 branch April 25, 2021 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation workflow Workflow improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants