-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous fixups #171
Merged
Merged
Miscellaneous fixups #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0f9d15f.
TypeScript does not use semantic versioning. See microsoft/TypeScript#14116
``` $ npx tsc --noEmit --project tsconfig.json src/common/fileManager.ts error TS5042: Option 'project' cannot be mixed with source files on a command line. ``` oh well
Without changing `lint-staged`: ``` ✖ tsc --noEmit --target 'es2016': src/debugger/debugDispatcher.ts(2,45): error TS2792: Cannot find module '@vscode/debugadapter'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option? ``` not easy to find details here, just going to `tsc` the whole project since it's still pretty speedy.
Matches https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode used in changelog, see also https://prettier.io/docs/en/install.html#:~:text=Even%20a%20patch%20release%20of%20Prettier%20can%20result%20in%20slightly%20different%20formatting "Even a patch release of Prettier can result in slightly different formatting"
mark-wiemer
commented
Jul 18, 2022
mark-wiemer
changed the title
Revert changes that broke debugger in 2.8.3
Miscellaneous fixups
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153.
Changes proposed in this pull request:
step_into
tostepInto
and similar values. AHK expects those exact values, not sure where that's documented though..match(/x/) !== null
with.includes('x')
for simplicity and perfReplace "ISSUE" and "CHANGE" above with your values.
Do not edit below:
Notifying @mark-wiemer