Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixups #171

Merged
merged 27 commits into from
Jul 18, 2022
Merged

Miscellaneous fixups #171

merged 27 commits into from
Jul 18, 2022

Conversation

mark-wiemer
Copy link
Owner

@mark-wiemer mark-wiemer commented Jul 18, 2022

Closes #153.

Changes proposed in this pull request:

  • Fix Debugger bug introduced with v2.8.3 #153 in main branch. Issue was changing step_into to stepInto and similar values. AHK expects those exact values, not sure where that's documented though.

    2.8.4 is published from a hotfix branch branch-v2.8.2 that won't be merged to main. Once this PR is merged, we can release 2.8.5 which will simply be 2.8.3 but without bug Debugger bug introduced with v2.8.3 #153

  • Revert changes that broke the debugger
  • Use consistent Prettier 2.6.1
  • Replace .match(/x/) !== null with .includes('x') for simplicity and perf

Replace "ISSUE" and "CHANGE" above with your values.

Do not edit below:

Notifying @mark-wiemer

@mark-wiemer mark-wiemer changed the title Fix 153 Revert changes that broke debugger in 2.8.3 Jul 18, 2022
TypeScript does not use semantic versioning. See microsoft/TypeScript#14116
```
$ npx tsc --noEmit --project tsconfig.json src/common/fileManager.ts
error TS5042: Option 'project' cannot be mixed with source files on a command line.
```

oh well
Without changing `lint-staged`:

```
✖ tsc --noEmit --target 'es2016':
src/debugger/debugDispatcher.ts(2,45): error TS2792: Cannot find module '@vscode/debugadapter'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
```

not easy to find details here, just going to `tsc` the whole project since it's still pretty speedy.
Keep known issue #40 to minimize merge conflicts with #163
@mark-wiemer mark-wiemer marked this pull request as ready for review July 18, 2022 06:35
@mark-wiemer mark-wiemer enabled auto-merge (squash) July 18, 2022 06:35
@mark-wiemer mark-wiemer changed the title Revert changes that broke debugger in 2.8.3 Miscellaneous fixups Jul 18, 2022
@mark-wiemer mark-wiemer merged commit bfc5cd7 into main Jul 18, 2022
@mark-wiemer mark-wiemer deleted the fix-153 branch July 18, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger bug introduced with v2.8.3
1 participant