Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple Silicon (M1) and Python v3.x support #11

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Apple Silicon (M1) and Python v3.x support #11

wants to merge 8 commits into from

Conversation

mikeoertli
Copy link

Release notes:

  • Builds off of Marius Kießling's great work and provides needed updates to support Apple Silicon Macs as well as moves to Python3.
  • Slightly changed the behavior of 'Enter' key after successful configuration, it will only connect (or no-op if already connected) rather than toggling current connection state.
  • Fixes issues with newer macOS versions (12.x) where retrieval and parsing of Bluetooth devices, their MAC addresses, and the connection status was unreliable. I didn't dig into the legacy behavior to know exactly what changed, but some combination of CLI utilities and how the MAC is represented (namely the delimiter – colon vs. dash) appears to be at least a culprit.
  • Fixed/improved some of the workflow verbiage and notes to clarify behavior
  • Added several debug taps

@mikeoertli
Fixes for M1 + python3
3258173 
This is designed to run with Python3. Only tested on an M1 series, but with a few small tweaks could run on intel too (the homebrew install path changed for M1)
There are added comments and several things have been pulled out into functions with more of the code being in scripts since that gives us control over which python version is used (Alfred's built-in python scripts just uses whichever is symlinked from /usr/bin)
New error icon for when there has been an error condition
@mikeoertli
Fixed issue w/ keyboard shortcut not toggling connection
f6498b0 
Fixed an issue where the python script output was ended with a newline, this broke the keyboard shortcut to toggle the connection
@mikeoertli
Fixes typo, shortens unconfigured title
aabc961
@mikeoertli
Fixes issue showing "unconfigured" state regularly
7e71cf4 
Fixes an issue where the "unconfigured" menu was appearing even when the workflow was configured.
Adds an error state and improved messaging with guidance on resetting the workflow variables
@mikeoertli
Fixes failed refactor variable rename
0567033
@mikeoertli
Removes false error status shown regularly
c6a9472
This was referenced Dec 31, 2021
Open
Open
@mikeoertli
Updated images, migrated to bluetoothconnector for everything, update…
f1af453 
…d readme

Updated images to use the latest version of AirPods
Removed (some of the) legacy parsing of system_profiler, now it just uses the bluetoothconnector utility for connection status and connect/disconnect status
Updated the readme to remove several old references
@mikeoertli
Updated readme to indicate this isn't maintained
0bb0cf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikeoertli