Added Appropriate nodiscards #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should be.
|
I just performed a change that undid the changes to spacing I did. Everything that should be [[nodiscard]] should still be be no discard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I was using the library and accidentally perform an error with
uuid::from_stringfunction. I would have caught the error if the function was[[nodiscard]]. So I added[[nodiscard]]to all functions that seemed appropriate.I didn't add it to the random generator function because for some reason someone may just want to cycle random numbers out of no where. Don't really know why, but I wasn't 100% sure so I didn't add it there.
I also may have horribly messed up the spacing on things. Apologies, I have class in 10 minutes and I will definitely forget about this entire thing by the end of it.