-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ioredis #137
Support for ioredis #137
Conversation
Thank you very much for this PR! A couple of questions/requests, since I never really looked into ioredis in depth:
|
Also, .DS_Store is a macOS specific file, right? Should probably be added to .gitignore instead of adding it to the repo :-) |
Thanks, sorry for delay - I'll take a look. |
So I think ioredis has the equivalent;
|
I made those changes, but the tests are failing (I think) at deleteNonExistant - might need some help to debug... |
Wasn't quite as simple as I had hoped, but now all tests pass with node_redis and ioredis. See #138 for the changes I added. I will probably close this one and then merge #138, unless you want to do some more work on any of this, then I'd recommend pulling in my 1 commit and then we can continue here. |
One thing that could still be added, but is entirely optional and could also go into its own PR is ioredis support in extra/stress.js. Documentation is also missing for now. |
Awesome, thanks! |
Added support for ioredis, issue #120, by converting uppercase function names to lowercase and reducing connection detection strictness