add bsd3 license #10
Merged
add bsd3 license #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhimmel
reviewed
Oct 26, 2018
LICENSE.md
Outdated
| @@ -0,0 +1,31 @@ | |||
| # Copyright (C) 2018 The Children's Hospital of Philadelphia | |||
There was a problem hiding this comment.
These copyright assertions aren't super important, so don't get caught up too much in perfecting it, but I don't think CHOP is the copyright owner of @gwaygenomics' contributions.
This should either be @gwaygenomics or University of Pennsylvania. You could always do something like:
Copyright (C) 2018 Contributors, The Children's Hospital of Philadelphia, and the University of Pennsylvania
to cover all the possibilities
There was a problem hiding this comment.
Also I don't think this should be h1 formatted. I would make it regular text and set a title of # BSD 3-Clause License
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs to be checked for correct copyright info