Call the itemViewContainer in the context of the CompositeView #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah nice, @TheCloudlessSky can you as a test for this? |
|
Sure thing. There wasn't any tests about |
|
cool thanks @TheCloudlessSky mind squashing the commit down into 1 then i think we will be good to go 🚢 |
Add tests for calling `itemViewContainer` in context of composite view. Call the `itemViewContainer` with the current context.
|
Sure thing. |
samccone
added a commit
that referenced
this pull request
Jan 8, 2014
Call the itemViewContainer in the context of the CompositeView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
itemViewContaineris specified as a function, it is called in the global context, which isn't cool. This fixes this issue by ensuring that theitemViewContaineris called in the context of theCompositeView.