Partial test cleanup #3395
Merged
Partial test cleanup #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds clean tests per file. This doesn't test the files that have no logic. Updates deprecate tests and ignores a difficult to test trivial line to reach 100% branching coverage.
paulfalgout
force-pushed
the
test/util-test-cleanup
branch
from
afa5e73 to
349b083
Compare
scott-w
approved these changes
Jun 26, 2017
|
This doesn't touch production code, and has a thumb, I'm going to merge it and we can fix anything anyone has an issue with later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3248
Adds clean tests per utils file.
This doesn't test the files that have no logic.
Updates deprecate tests and ignores a difficult to test trivial line to reach 100% branching coverage.
This also moves as many files as were easy into the same file structure as the code.