Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component.json #2664

Merged
merged 1 commit into from
Jul 20, 2015
Merged

Conversation

cmisenas
Copy link
Contributor

@cmisenas cmisenas commented Jul 9, 2015

Fixes #2601

@pascalpp
Copy link
Contributor

Does marionette also need to be 'unpublished' from component?

@cmisenas cmisenas force-pushed the remove-components-json branch from 435bc91 to 38b72d8 Compare July 10, 2015 14:45
@cmisenas
Copy link
Contributor Author

Good question. Looks like they use a wiki page. They also have a new crawler thing but it looks like marionette is not yet included there.

@samccone
Copy link
Member

I think doing this would be a breaking change right?

@pascalpp
Copy link
Contributor

No match for marionette on http://component.github.io. So maybe it was never published to component?

@cmisenas
Copy link
Contributor Author

@pascalpp It is on the old registry (their wiki page) which I believe is still being used cause I can run component install marionette successfully.

@samccone yes. From my understanding though reading #2601 is that not many people are using it nowadays. Also there's this blog post and this issue

@ahumphreys87
Copy link
Member

yup this would be breaking, its going into next though so that's fine - we just dont push till 3.0.

👍

jasonLaster added a commit that referenced this pull request Jul 20, 2015
@jasonLaster jasonLaster merged commit 1abc4d5 into marionettejs:next Jul 20, 2015
@jasonLaster
Copy link
Member

Merged. Thanks @cmisenas! We can always re-add if this registry takes off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants