-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update marionette.itemview.md #1907
Conversation
The old example for 'variable' in the documentation did not work for me. The 'settings' argument is the 2nd or 3rd argument of the _.template function. The model is then passed in as a parameter to the then generated template function. I attempted to update the documentation to reflect this.
@bafolts are you on Underscore 1.7 by chance? |
That is the one. Sorry, most likely could have included that with the pull request. |
Underscore 1.7 is not supported in Marionette due to numerous breaking changes in that version. ref #1833 For now just use 1.6 |
Removing the specific reference to the "variable" settings for underscore could help for now. That was the only misleading part and really isn't related to Marionette as it is underscore. All that really matters in Marionette is that I can call _.template from the function passed in for 'template'. |
I admit I haven't had the time to look at the issue of 1.7 in Marionette too much, but if a documentation change could help people out then I think we should think more about it. |
Updated description for 'template' function to allow for more ambiguity between versions of underscore.
manually merged thanks! |
The old example for 'variable' in the documentation did not work for me. The 'settings' argument is the 2nd or 3rd argument of the _.template function. The model is then passed in as a parameter to the then generated template function. I attempted to update the documentation to reflect this.