Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marionette.itemview.md #1907

Closed
wants to merge 2 commits into from
Closed

Conversation

bafolts
Copy link
Contributor

@bafolts bafolts commented Sep 16, 2014

The old example for 'variable' in the documentation did not work for me. The 'settings' argument is the 2nd or 3rd argument of the _.template function. The model is then passed in as a parameter to the then generated template function. I attempted to update the documentation to reflect this.

The old example for 'variable' in the documentation did not work for me. The 'settings' argument is the 2nd or 3rd argument of the _.template function. The model is then passed in as a parameter to the then generated template function. I attempted to update the documentation to reflect this.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9319c27 on bafolts:patch-1 into f65e4cd on marionettejs:master.

@samccone
Copy link
Member

@bafolts are you on Underscore 1.7 by chance?

@bafolts
Copy link
Contributor Author

bafolts commented Sep 16, 2014

That is the one. Sorry, most likely could have included that with the pull request.

@samccone
Copy link
Member

Underscore 1.7 is not supported in Marionette due to numerous breaking changes in that version.

ref #1833
ref jashkenas/underscore#1805

For now just use 1.6

@samccone samccone closed this Sep 16, 2014
@jamesplease
Copy link
Member

Thanks for the report @bafolts. As @samccone pointed out we're stuck on 1.6 due to the breaking changes in 1.7. We try to keep Marionette backwards compatible, so it might be some time before we can make the change to support 1.7.

@bafolts
Copy link
Contributor Author

bafolts commented Sep 16, 2014

Removing the specific reference to the "variable" settings for underscore could help for now. That was the only misleading part and really isn't related to Marionette as it is underscore. All that really matters in Marionette is that I can call _.template from the function passed in for 'template'.

@jamesplease jamesplease reopened this Sep 16, 2014
@jamesplease
Copy link
Member

I admit I haven't had the time to look at the issue of 1.7 in Marionette too much, but if a documentation change could help people out then I think we should think more about it.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9319c27 on bafolts:patch-1 into f65e4cd on marionettejs:master.

Updated description for 'template' function to allow for more ambiguity between versions of underscore.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6f52fec on bafolts:patch-1 into f65e4cd on marionettejs:master.

@samccone
Copy link
Member

manually merged

thanks!

@samccone samccone closed this Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants