Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child view region issue of v3.4.1 #3424

Closed
JounQin opened this issue Aug 13, 2017 · 3 comments
Closed

Child view region issue of v3.4.1 #3424

JounQin opened this issue Aug 13, 2017 · 3 comments
Labels
bug in progress
Milestone
v3.4.2

Comments

@JounQin
Copy link

JounQin commented Aug 13, 2017

Description

When there is an unused region in childView of collectionView, it will try to replace elements outside of collectionView!

Expected behavior

Should only find region in childView rather than outside of collectionView

Actual behavior

https://jsfiddle.net/JounQin/L8vrbsdd/

Environment

  1. Marionette version: 3.4.1
  2. Backbone version: 1.3.3
  3. Additional build tools, etc: none
@paulfalgout
Copy link
Member

So.. I do think there's likely an over-selective region issue here.. unfortunately fixing it will be breaking. This will ultimately be resolved with a solution like: #3417

@JounQin
Copy link
Author

JounQin commented Aug 14, 2017

@paulfalgout It actually works on v3.3.1

https://jsfiddle.net/ayju8k3h/1/

@paulfalgout paulfalgout added this to the v3.4.2 milestone Aug 14, 2017
paulfalgout added a commit to paulfalgout/backbone.marionette that referenced this issue Aug 14, 2017
@paulfalgout
If region selector is not found within a given context return nothing
61e1a2c 
Resolves marionettejs#3424

v3.4.0 introduced a region selector
@paulfalgout paulfalgout mentioned this issue Aug 14, 2017
Merged
JSteunou pushed a commit that referenced this issue Aug 16, 2017
@paulfalgout @JSteunou
If region selector is not found within a given context return nothing (…
4af7db8 
…#3425)

Resolves #3424

v3.4.0 introduced a region selector
@JSteunou
Copy link
Contributor

solved by #3425 which will be out with 3.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug in progress
Projects
None yet
Milestone
v3.4.2
Development

No branches or pull requests
3 participants
@paulfalgout @JSteunou @JounQin