Drop dependency on deprecated gulp-util
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demurgos
suggested changes
Dec 30, 2017
| "rework": "~1.0.0", | ||
| "rework-import": "^2.0.0", | ||
| "rework-plugin-url": "^1.0.1", | ||
| "through2": "~1.1.1" | ||
| "through2": "~1.1.1", | ||
| "vinyl": "^2.1.0" |
There was a problem hiding this comment.
vinyl should be in the devDependencies. Could you update it please?
There was a problem hiding this comment.
I don't think so, as it's being used in index.js, not only the tests.
There was a problem hiding this comment.
You're right, it's a normal dependency (I'm going over too much of these PRs 😄)
demurgos
approved these changes
Dec 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gulp-utilhas been deprecated recently. Continuing to use this dependency may prevent the use of your library with the latest release of Gulp 4 so it is important to replacegulp-util.Your package is one of the most popular packages still relying on
gulp-util, it would be good to publish a fixed version to npm as soon as possible.See: